[webkit-changes] [WebKit/WebKit] bf377f: [WebGPU] Using fp16 as an override value will crash

mwyrzykowski noreply at github.com
Tue Dec 5 15:32:31 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bf377f517c58a0fa63e1880a33606bc4b639b59a
      https://github.com/WebKit/WebKit/commit/bf377f517c58a0fa63e1880a33606bc4b639b59a
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-12-05 (Tue, 05 Dec 2023)

  Changed paths:
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
    M Source/WebGPU/WGSL/WGSL.h
    M Source/WebGPU/WebGPU/Pipeline.mm

  Log Message:
  -----------
  [WebGPU] Using fp16 as an override value will crash
https://bugs.webkit.org/show_bug.cgi?id=265889
<radar://119199267>

Reviewed by Dan Glastonbury.

std::get crashes if ConstantValue contained a WGSL::half,
add support for WGSL::half for override values.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::usesOverride):
* Source/WebGPU/WGSL/WGSL.h:
* Source/WebGPU/WebGPU/Pipeline.mm:
(WebGPU::createConstantValues):

Canonical link: https://commits.webkit.org/271576@main




More information about the webkit-changes mailing list