[webkit-changes] [WebKit/WebKit] b151ff: [Wasm-GC] Fix casts on larger type indices

Asumu Takikawa noreply at github.com
Tue Dec 5 14:10:09 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b151ff2597f06f8bf46945a2db052db6a634b8b6
      https://github.com/WebKit/WebKit/commit/b151ff2597f06f8bf46945a2db052db6a634b8b6
  Author: Asumu Takikawa <asumu at igalia.com>
  Date:   2023-12-05 (Tue, 05 Dec 2023)

  Changed paths:
    M JSTests/wasm/gc/casts.js
    M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp
    M Source/JavaScriptCore/wasm/WasmFunctionParser.h

  Log Message:
  -----------
  [Wasm-GC] Fix casts on larger type indices
https://bugs.webkit.org/show_bug.cgi?id=265720

Reviewed by Justin Michaud.

Fix some bad C++ casts in the implementation of ref.cast that were causing
casts with larger type indices to fail to validate.

Also fixes another issue with cast validation, for the null-ness of the output
type.

* JSTests/wasm/gc/casts.js:
(testValidation):
* Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::emitRefTestOrCast):
* Source/JavaScriptCore/wasm/WasmFunctionParser.h:
(JSC::Wasm::FunctionParser<Context>::parseExpression):

Canonical link: https://commits.webkit.org/271571@main




More information about the webkit-changes mailing list