[webkit-changes] [WebKit/WebKit] 9610a6: Fix depencency cycle in build

Elliott Williams noreply at github.com
Tue Dec 5 13:44:24 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9610a6aafa77230e02e955bf794c16aa5ad0a46f
      https://github.com/WebKit/WebKit/commit/9610a6aafa77230e02e955bf794c16aa5ad0a46f
  Author: Elliott Williams <emw at apple.com>
  Date:   2023-12-05 (Tue, 05 Dec 2023)

  Changed paths:
    M Source/WebKit/Modules/OSX_Private.modulemap
    M Source/WebKit/Modules/iOS_Private.modulemap
    M Source/WebKit/Platform/ExtraPrivateSymbolsForTAPI.h
    M Source/WebKit/Shared/AuxiliaryProcessExtensions/AuxiliaryProcessExtensionBridge.h
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Fix depencency cycle in build
https://bugs.webkit.org/show_bug.cgi?id=265870
rdar://119162443

Reviewed by Per Arne Vollan.

Swift code in WebKit extension targets (really any targets that are part of
the WebKit project and depend on WebKit.framework) cannot import
WebKit's swiftmodule without causing a cycle in the internal OS build.
This is because WebKit's Swift overlay builds in a separate project.

Fix by making WKProcessExtension.h a non-modular header, so that the
extension targets can bridge it without pulling in all of WebKit.

* Source/WebKit/Modules/OSX_Private.modulemap:
* Source/WebKit/Modules/iOS_Private.modulemap:
* Source/WebKit/Platform/ExtraPrivateSymbolsForTAPI.h:
* Source/WebKit/Shared/AuxiliaryProcessExtensions/AuxiliaryProcessExtensionBridge.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/271568@main




More information about the webkit-changes mailing list