[webkit-changes] [WebKit/WebKit] a2d071: Make a couple more http/tests/security tests use w...

[sideshowbarker]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a2d071de9311b41a64f727f86be2f2e2bd0fc68e
      https://github.com/WebKit/WebKit/commit/a2d071de9311b41a64f727f86be2f2e2bd0fc68e
  Author: Michael[tm] Smith <mike at w3.org>
  Date:   2023-12-05 (Tue, 05 Dec 2023)

  Changed paths:
    M LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window2-expected.txt
    M LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html
    M LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window3-expected.txt
    M LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html

  Log Message:
  -----------
  Make a couple more http/tests/security tests use window.internals.isFullyActive(Document&)
https://bugs.webkit.org/show_bug.cgi?id=265101

Reviewed by David Kilzer.

This change updates two http/tests/security tests to use the (recently-added)
window.internals.isFullyActive(Document&) function.

https://commits.webkit.org/270737 added a window.internals.isFullyActive(Document&)
function — for cases where it’s necessary for a test to ensure whether or not a
particular document is fully active — and used that to update (fix) the test at
http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html,
which its last update in https://commits.webkit.org/269235@main had made flaky.

And in the https://commits.webkit.org/269235@main change which caused
that http/tests/security test to become flaky, two companion tests had
also been updated in the same way that had caused the flakiness in that
other test (before it was subsequently fixed).

So, while the two other companion tests have not yet been flaky,
applying the same window.internals.isFullyActive(Document&) fix to them
ensures they’re actually working as expected — that is, actually testing
what they’re intended to be testing — and not at risk of becoming flaky
later due to the same underlying problem.

* LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window2-expected.txt:
* LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html:
* LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window3-expected.txt:
* LayoutTests/http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html:

Canonical link: https://commits.webkit.org/271565@main