[webkit-changes] [WebKit/WebKit] 6e2b89: Replace bools in PDFContextMenuItem with enum clas...

Sammy Gill noreply at github.com
Tue Dec 5 08:10:30 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6e2b89f53e56d4171becce375bf908ce725e9d30
      https://github.com/WebKit/WebKit/commit/6e2b89f53e56d4171becce375bf908ce725e9d30
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2023-12-05 (Tue, 05 Dec 2023)

  Changed paths:
    M Source/WebKit/Shared/mac/PDFContextMenu.h
    M Source/WebKit/Shared/mac/PDFContextMenuItem.serialization.in
    M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  Replace bools in PDFContextMenuItem with enum classes.
https://bugs.webkit.org/show_bug.cgi?id=265815.
rdar://problem/119150073.

Reviewed by Simon Fraser.

enabled, separator, and hasAction are all bools which can be represented
as an enum class.

* Source/WebKit/Shared/mac/PDFContextMenu.h:
* Source/WebKit/Shared/mac/PDFContextMenuItem.serialization.in:
* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::showPDFContextMenu):
* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::handleContextMenuEvent):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::createContextMenu const):

Canonical link: https://commits.webkit.org/271554@main




More information about the webkit-changes mailing list