[webkit-changes] [WebKit/WebKit] 641ae4: [scroll-animations] add parsing support for the `v...

Antoine Quint noreply at github.com
Tue Dec 5 01:37:04 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 641ae4b07d5a0201599bc504044ff36fc94c7ce5
      https://github.com/WebKit/WebKit/commit/641ae4b07d5a0201599bc504044ff36fc94c7ce5
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-12-05 (Tue, 05 Dec 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-computed-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-parsing-expected.txt
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/animation/ScrollTimeline.h
    M Source/WebCore/animation/ViewTimeline.cpp
    M Source/WebCore/animation/ViewTimeline.h
    M Source/WebCore/css/CSSProperties.json
    M Source/WebCore/css/CSSToStyleMap.cpp
    M Source/WebCore/css/CSSValue.cpp
    M Source/WebCore/css/CSSValue.h
    A Source/WebCore/css/CSSViewValue.cpp
    A Source/WebCore/css/CSSViewValue.h
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/parser/CSSPropertyParser.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
    M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
    M Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js

  Log Message:
  -----------
  [scroll-animations] add parsing support for the `view()` notation of the `animation-timeline` property
https://bugs.webkit.org/show_bug.cgi?id=265792

Reviewed by Antti Koivisto.

We now add parsing support for the `view()` notation of the `animation-timeline` property using a new
`CSSValue` subclass: `CSSViewValue`. This will yield an anonymous `ViewTimeline`.

* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-parsing-expected.txt:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/ScrollTimeline.h:
* Source/WebCore/animation/ViewTimeline.cpp:
(WebCore::ViewTimeline::createFromCSSValue):
(WebCore::ViewTimeline::toCSSValue const):
* Source/WebCore/animation/ViewTimeline.h:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapAnimationTimeline):
* Source/WebCore/css/CSSValue.cpp:
(WebCore::CSSValue::visitDerived):
* Source/WebCore/css/CSSValue.h:
(WebCore::CSSValue::isViewValue const):
* Source/WebCore/css/CSSViewValue.cpp: Added.
(WebCore::CSSViewValue::customCSSText const):
(WebCore::CSSViewValue::equals const):
* Source/WebCore/css/CSSViewValue.h: Added.
* Source/WebCore/css/ComputedStyleExtractor.cpp:
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::consumeAnimationValueForShorthand):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeAnimationTimeline):
(WebCore::CSSPropertyParserHelpers::consumeSingleAnimationTimeline):
(WebCore::CSSPropertyParserHelpers::consumeAnimationTimelineView):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:

Canonical link: https://commits.webkit.org/271544@main




More information about the webkit-changes mailing list