[webkit-changes] [WebKit/WebKit] 634bc0: [iPad] Fullscreening a Youtube video while in Ligh...
Jer Noble
noreply at github.com
Mon Dec 4 22:38:48 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 634bc0b60bf0013b8d061f8e1dd3faeeb93653e4
https://github.com/WebKit/WebKit/commit/634bc0b60bf0013b8d061f8e1dd3faeeb93653e4
Author: Jer Noble <jer.noble at apple.com>
Date: 2023-12-04 (Mon, 04 Dec 2023)
Changed paths:
M LayoutTests/fullscreen/full-screen-document-background-color-expected.txt
M LayoutTests/fullscreen/full-screen-document-background-color.html
A LayoutTests/fullscreen/resources/backdrop-green.html
A LayoutTests/fullscreen/resources/backdrop-red-on-green.html
M Source/WebCore/page/LocalFrameView.cpp
Log Message:
-----------
[iPad] Fullscreening a Youtube video while in Light Mode causes a white bar across the top and bottom of the screen
https://bugs.webkit.org/show_bug.cgi?id=264985
rdar://118530255
Reviewed by Tim Nguyen.
Tests updated: fullscreen/full-screen-document-background-color.html
Take the :fullscreen::backdrop element into account when calculating the documentBackgroundColor.
This will be black by default, so even for websites that have a clear background color on their
fullscreen element, the documentBackgroundColor should usually calculate to black. (Unless they
override the backdrop color, in which case this would the site's preferred behavior).
* LayoutTests/fullscreen/full-screen-document-background-color-expected.txt:
* LayoutTests/fullscreen/full-screen-document-background-color.html:
* LayoutTests/fullscreen/resources/backdrop-green-on-red.html: Added.
* LayoutTests/fullscreen/resources/backdrop-green.html: Added.
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::documentBackgroundColor const):
Canonical link: https://commits.webkit.org/271535@main
More information about the webkit-changes
mailing list