[webkit-changes] [WebKit/WebKit] 5aefb4: [IFC][Ruby] Apply ruby-align on line content

Alan Baradlay noreply at github.com
Mon Dec 4 18:51:56 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5aefb4085f13a387a6a4c11ef2d8f7b437889070
      https://github.com/WebKit/WebKit/commit/5aefb4085f13a387a6a4c11ef2d8f7b437889070
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLine.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h

  Log Message:
  -----------
  [IFC][Ruby] Apply ruby-align on line content
https://bugs.webkit.org/show_bug.cgi?id=265768

Reviewed by Antti Koivisto.

Move ruby-align adjustment to where we also apply text-align: justify (end of line handling).

* Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::initialize):
(WebCore::Layout::Line::applyRunExpansion):
(WebCore::Layout::Line::moveBy):
(WebCore::Layout::Line::expandBy):
(WebCore::Layout::Line::appendInlineBoxStart):
(WebCore::Layout::Line::moveRunsBy): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLine.h:
(WebCore::Layout::Line::hasRubyContent const):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::placeInlineAndFloatContent):
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::applyRubyAlignOnBaseContent):
(WebCore::Layout::RubyFormattingContext::applyRubyAlign):
(WebCore::Layout::RubyFormattingContext::layoutRubyBaseInlineAxis): This is dead code now. About to be removed.
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.h:

Canonical link: https://commits.webkit.org/271523@main




More information about the webkit-changes mailing list