[webkit-changes] [WebKit/WebKit] 42db72: Make has_json_wrapper and strip_json_wrapper private

Sam Sneddon noreply at github.com
Mon Dec 4 13:11:13 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 42db72e3286bd02966fb16ea679d33e4e49ade3e
      https://github.com/WebKit/WebKit/commit/42db72e3286bd02966fb16ea679d33e4e49ade3e
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
    M Tools/Scripts/webkitpy/common/net/resultsjsonparser.py
    M Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py
    M Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py
    M Tools/Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py

  Log Message:
  -----------
  Make has_json_wrapper and strip_json_wrapper private
https://bugs.webkit.org/show_bug.cgi?id=265692

Reviewed by Jonathan Bedard.

This makes it very obvious nothing is actually using these, and allows
us to have the confidence both JSON and JSONP work everywhere.

* Tools/Scripts/webkitpy/common/net/resultsjsonparser.py:
(ParsedJSONResults.__init__):
* Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(_has_json_wrapper):
(_strip_json_wrapper):
(load_json):
(load_jsons):
(has_json_wrapper): Deleted.
(strip_json_wrapper): Deleted.
* Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
(JSONGeneratorTest.test_load_jsons):
(JSONGeneratorTest.test_strip_json_wrapper): Deleted.
* Tools/Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
(RebaselineTestTest.test_gather_baselines):

Canonical link: https://commits.webkit.org/271505@main




More information about the webkit-changes mailing list