[webkit-changes] [WebKit/WebKit] fb8f99: [IFC][Ruby] Can't add interlinear annotation displ...
Alan Baradlay
noreply at github.com
Mon Dec 4 13:02:19 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fb8f991e77edc6302663831bc094bf8d6869b919
https://github.com/WebKit/WebKit/commit/fb8f991e77edc6302663831bc094bf8d6869b919
Author: Alan Baradlay <zalan at apple.com>
Date: 2023-12-04 (Mon, 04 Dec 2023)
Changed paths:
M LayoutTests/TestExpectations
M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h
Log Message:
-----------
[IFC][Ruby] Can't add interlinear annotation display box until bidi content is processed
https://bugs.webkit.org/show_bug.cgi?id=265759
Reviewed by Antti Koivisto.
This patch is in preparation for supporting bidi content in ruby.
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
Move annotation box construction to a later time when we finished constructing all the display boxes. It ensures
such annotation boxes get to their correct _visual_ positions.
(WebCore::Layout::InlineDisplayContentBuilder::build):
(WebCore::Layout::InlineDisplayContentBuilder::appendInlineBoxDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendSpanningInlineBoxDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendInlineDisplayBoxAtBidiBoundary):
(WebCore::Layout::InlineDisplayContentBuilder::insertRubyAnnotationBox):
(WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent):
(WebCore::Layout::InlineDisplayContentBuilder::processRubyContent):
(WebCore::Layout::InlineDisplayContentBuilder::applyRubyOverhang):
(WebCore::Layout::InlineDisplayContentBuilder::handleInlineBoxEnd): Deleted.
(WebCore::Layout::InlineDisplayContentBuilder::appendRubyAnnotationBox): Deleted.
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h:
Canonical link: https://commits.webkit.org/271503@main
More information about the webkit-changes
mailing list