[webkit-changes] [WebKit/WebKit] f0f457: [WGSL] Explicit type conversion should not check f...
Tadeu Zagallo
noreply at github.com
Mon Dec 4 12:26:16 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f0f4573a7ded9af3e7e471119cb17cee0f25a0d1
https://github.com/WebKit/WebKit/commit/f0f4573a7ded9af3e7e471119cb17cee0f25a0d1
Author: Tadeu Zagallo <tzagallo at apple.com>
Date: 2023-12-04 (Mon, 04 Dec 2023)
Changed paths:
M Source/WebGPU/WGSL/ConstantFunctions.h
M Source/WebGPU/WGSL/TypeCheck.cpp
M Source/WebGPU/WGSL/tests/valid/overload.wgsl
Log Message:
-----------
[WGSL] Explicit type conversion should not check for overflow
https://bugs.webkit.org/show_bug.cgi?id=265688
rdar://119044778
Reviewed by Mike Wyrzykowski.
When converting values to a different type (e.g. u32(i32)), we should not perform
the same overflow checks as when a type is implicitly converted (e.g. from AbstractInt
to i32).
* Source/WebGPU/WGSL/ConstantFunctions.h:
(WGSL::convertValue):
(WGSL::constantConstructor):
(WGSL::constantVector):
(WGSL::constantMatrix):
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::chooseOverload):
(WGSL::TypeChecker::convertValue):
* Source/WebGPU/WGSL/tests/valid/overload.wgsl:
Canonical link: https://commits.webkit.org/271499@main
More information about the webkit-changes
mailing list