[webkit-changes] [WebKit/WebKit] 7097e3: [view-transitions] Implement "capture new state" a...

Tim Nguyen noreply at github.com
Mon Dec 4 08:57:31 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7097e3442fce1622b1104d3bbc6b9040a05672ca
      https://github.com/WebKit/WebKit/commit/7097e3442fce1622b1104d3bbc6b9040a05672ca
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/duplicate-tag-rejects-capture-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/duplicate-tag-rejects-start-expected.txt
    M Source/WebCore/dom/ViewTransition.cpp
    M Source/WebCore/dom/ViewTransition.h

  Log Message:
  -----------
  [view-transitions] Implement "capture new state" algorithm
https://bugs.webkit.org/show_bug.cgi?id=265715
rdar://119068808

Reviewed by Simon Fraser.

This commit:
- makes the "named elements" map use a custom built ordered map, since insertion order will be important when building the pseudo elements and rendering them
The pseudo element construction will be done in: https://github.com/WebKit/WebKit/pull/21205

- implements the "capture new state" algorithm which simply re-validates the "named elements" map and throws an error if needed
- fixes error handling for the "capture old state" algorithm.

Spec:
- capture old state: https://drafts.csswg.org/css-view-transitions/#capture-old-state-algorithm
- capture new state: https://drafts.csswg.org/css-view-transitions/#capture-new-state-algorithm
- named elements: https://drafts.csswg.org/css-view-transitions/#viewtransition-named-elements

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/duplicate-tag-rejects-capture-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/duplicate-tag-rejects-start-expected.txt:
* Source/WebCore/dom/ViewTransition.cpp:
(WebCore::ViewTransition::setupViewTransition):
(WebCore::effectiveViewTransitionName):
(WebCore::checkDuplicateViewTransitionName):
(WebCore::ViewTransition::captureOldState):
(WebCore::ViewTransition::captureNewState):
(WebCore::ViewTransition::activateViewTransition):
* Source/WebCore/dom/ViewTransition.h:
(WebCore::OrderedNamedElementsMap::contains const):
(WebCore::OrderedNamedElementsMap::add):
(WebCore::OrderedNamedElementsMap::remove):
(WebCore::OrderedNamedElementsMap::keys const):
(WebCore::OrderedNamedElementsMap::find):
(WebCore::ViewTransition::namedElements const):

Canonical link: https://commits.webkit.org/271483@main




More information about the webkit-changes mailing list