[webkit-changes] [WebKit/WebKit] 4b3c62: Adopt -[UIScrollView showScrollIndicatorsForConten...

Wenson Hsieh noreply at github.com
Mon Dec 4 08:18:48 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4b3c6264047e1aba121521b83cf2a7e72c0435c5
      https://github.com/WebKit/WebKit/commit/4b3c6264047e1aba121521b83cf2a7e72c0435c5
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-12-04 (Mon, 04 Dec 2023)

  Changed paths:
    M Source/WebKit/UIProcess/ios/UIKitUtilities.h
    M Source/WebKit/UIProcess/ios/UIKitUtilities.mm
    M Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm

  Log Message:
  -----------
  Adopt -[UIScrollView showScrollIndicatorsForContentOffsetChanges:] for animated keyboard scrolling
https://bugs.webkit.org/show_bug.cgi?id=265765
rdar://119105952

Reviewed by Richard Robinson.

Stop using `-_flashScrollIndicatorsForAxes:persistingPreviousFlashes:` to show scroll indicators
after programmatically changing the content offset during animated keyboard scrolling; instead,
adopt `-showScrollIndicatorsForContentOffsetChanges:`, if available; with this new API, UIKit will
show scroll indicators on any axes that are programmatically scrolled during the call to the given
ObjC block, automatically persisting previous flashes.

* Source/WebKit/UIProcess/ios/UIKitUtilities.h:
* Source/WebKit/UIProcess/ios/UIKitUtilities.mm:
(axesForDelta):
(-[UIScrollView _wk_setContentOffsetAndShowScrollIndicators:animated:]):
* Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm:
(-[WKKeyboardScrollViewAnimator scrollToContentOffset:animated:]):
(axesForDelta): Deleted.

Canonical link: https://commits.webkit.org/271480@main




More information about the webkit-changes mailing list