[webkit-changes] [WebKit/WebKit] 4eceb1: [scroll-animations] add parsing support for the `s...
Antoine Quint
noreply at github.com
Mon Dec 4 08:02:26 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4eceb1199abdee3b067ad3675692c8036917332c
https://github.com/WebKit/WebKit/commit/4eceb1199abdee3b067ad3675692c8036917332c
Author: Antoine Quint <graouts at webkit.org>
Date: 2023-12-04 (Mon, 04 Dec 2023)
Changed paths:
M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-computed-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-parsing-expected.txt
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/animation/ScrollTimeline.cpp
M Source/WebCore/animation/ScrollTimeline.h
M Source/WebCore/css/CSSProperties.json
A Source/WebCore/css/CSSScrollValue.cpp
A Source/WebCore/css/CSSScrollValue.h
M Source/WebCore/css/CSSToStyleMap.cpp
M Source/WebCore/css/CSSValue.cpp
M Source/WebCore/css/CSSValue.h
M Source/WebCore/css/CSSValueKeywords.in
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp
M Source/WebCore/css/parser/CSSPropertyParserHelpers.h
M Source/WebCore/platform/animation/Animation.cpp
M Source/WebCore/platform/animation/Animation.h
M Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js
Log Message:
-----------
[scroll-animations] add parsing support for the `scroll()` notation of the `animation-timeline` property
https://bugs.webkit.org/show_bug.cgi?id=265786
Reviewed by Antti Koivisto.
We now add parsing support for the `scroll()` notation of the `animation-timeline` property using a new
`CSSValue` subclass: `CSSScrollValue`. This will yield an anonymous `ScrollTimeline`.
* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-computed-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/animation-timeline-parsing-expected.txt:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/animation/ScrollTimeline.cpp:
(WebCore::ScrollTimeline::createFromCSSValue):
(WebCore::ScrollTimeline::ScrollTimeline):
(WebCore::ScrollTimeline::toCSSValue const):
* Source/WebCore/animation/ScrollTimeline.h:
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/CSSScrollValue.cpp: Added.
(WebCore::CSSScrollValue::customCSSText const):
(WebCore::CSSScrollValue::equals const):
* Source/WebCore/css/CSSScrollValue.h: Added.
* Source/WebCore/css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapAnimationTimeline):
* Source/WebCore/css/CSSValue.cpp:
(WebCore::CSSValue::visitDerived):
* Source/WebCore/css/CSSValue.h:
(WebCore::CSSValue::isScrollValue const):
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::valueForAnimationTimeline):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeSingleAnimationTimeline):
(WebCore::CSSPropertyParserHelpers::consumeAnimationTimelineScroll):
* Source/WebCore/css/parser/CSSPropertyParserHelpers.h:
* Source/WebCore/platform/animation/Animation.cpp:
(WebCore::operator<<):
* Source/WebCore/platform/animation/Animation.h:
* Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:
Canonical link: https://commits.webkit.org/271477@main
More information about the webkit-changes
mailing list