[webkit-changes] [WebKit/WebKit] 25e194: [iOS] Revert to using AVAudioSession for determini...

aestes noreply at github.com
Sun Dec 3 21:55:07 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 25e1940919d2149a66dec7322c9df7f17ee0ea61
      https://github.com/WebKit/WebKit/commit/25e1940919d2149a66dec7322c9df7f17ee0ea61
  Author: Andy Estes <aestes at apple.com>
  Date:   2023-12-03 (Sun, 03 Dec 2023)

  Changed paths:
    M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
    R Source/WebCore/PAL/pal/spi/ios/MediaExperienceAVSystemControllerSPI.h
    M Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm

  Log Message:
  -----------
  [iOS] Revert to using AVAudioSession for determining the default microphone
https://bugs.webkit.org/show_bug.cgi?id=265704
rdar://113404912

Reviewed by Eric Carlson.

In iOS 16 AVAudioSession had a bug where the shared session's -currentRoute would not match the
user's selected route in Control Center if the user had previously changed the microphone input on a
site using MediaStream in Safari. To work around this bug, 253921 at main and 264070 at main started
using AVSystemController SPI to determine the route selected in Control Center.

In iOS 17 this bug no longer occurs, and -[AVAudioSession currentRoute] reflects the currently
selected route even after it has been temporarily changed by the user on a webpage in Safari.
Therefore, this change reverts 253921 at main and 264070 at main.

No new tests. Manually verified that the issues described by bugs 241632 and 254978 no longer
reproduce on https://webrtc.github.io/samples/src/content/devices/input-output/.

* Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:
* Source/WebCore/PAL/pal/spi/ios/MediaExperienceAVSystemControllerSPI.h: Removed.
* Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:
(WebCore::AVAudioSessionCaptureDeviceManager::retrieveAudioSessionCaptureDevices const):
(SOFT_LINK_CONSTANT): Deleted.
(): Deleted.
(WebCore::computeDefaultMicrophoneInformation): Deleted.

Canonical link: https://commits.webkit.org/271454@main




More information about the webkit-changes mailing list