[webkit-changes] [WebKit/WebKit] f8d357: CSS Counters not properly updated on style changes

Ahmad Saleem noreply at github.com
Sun Dec 3 17:31:15 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f8d357e1814f503c9df5fdc766855eb805bf5b67
      https://github.com/WebKit/WebKit/commit/f8d357e1814f503c9df5fdc766855eb805bf5b67
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-12-03 (Sun, 03 Dec 2023)

  Changed paths:
    A LayoutTests/fast/css/counters/counter-increment-not-reflected-on-stylechange-expected.txt
    A LayoutTests/fast/css/counters/counter-increment-not-reflected-on-stylechange.html
    M Source/WebCore/rendering/RenderCounter.cpp

  Log Message:
  -----------
  CSS Counters not properly updated on style changes

https://bugs.webkit.org/show_bug.cgi?id=256540
rdar://problem/109416780

Reviewed by Simon Fraser.

This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.

Merge: https://src.chromium.org/viewvc/blink?view=revision&revision=197703

When oldstyle does not have counterDirectives and
new style have counterDirectives on style change
previous counter nodes were not cleared because of
which oldstyle values are reflected.

* Source/WebCore/rendering/RenderCounter.cpp:
(enderCounter::rendererStyleChangedSlowCase):
* LayoutTests/fast/css/counters/counter-increment-not-reflected-on-stylechange.html: Add Test Case
* LayoutTests/fast/css/counters/counter-increment-not-reflected-on-stylechange-expected.txt: Add Test Case Expectation

Canonical link: https://commits.webkit.org/271451@main




More information about the webkit-changes mailing list