[webkit-changes] [WebKit/WebKit] 6a92ad: [UnifiedPDF] Start creating context menu in Unifie...

Sammy Gill noreply at github.com
Sat Dec 2 10:19:12 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6a92aded2a217de967647f6a04139b078abf36c5
      https://github.com/WebKit/WebKit/commit/6a92aded2a217de967647f6a04139b078abf36c5
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2023-12-02 (Sat, 02 Dec 2023)

  Changed paths:
    M Source/WebCore/en.lproj/Localizable.strings
    M Source/WebCore/platform/LocalizedStrings.cpp
    M Source/WebCore/platform/LocalizedStrings.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm

  Log Message:
  -----------
  [UnifiedPDF] Start creating context menu in UnifiedPDFPlugin.
https://bugs.webkit.org/show_bug.cgi?id=265605
rdar://119001947

Reviewed by Simon Fraser.

UnifiedPDF will need to start creating its own context menu so we can
lay the initial groundwork by creating a context menu with a single
item. This will hopefully allow us to easily add additional items in
a subsequent patch without worrying about the architecture too much.
In this patch the item we will use will be the "Open with Preview,"
option.

UnifiedPDFPlugin will create its own PDFContextMenu with items and
send this over to the web page proxy. Each item will contain a tag that
is a ContextMenuAction that will be used to indicate what type of action
to perform once we get the result back.

* Source/WebCore/en.lproj/Localizable.strings:
* Source/WebCore/platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemPDFOpenWithPreview):
* Source/WebCore/platform/LocalizedStrings.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::createContextMenu const):
(WebKit::UnifiedPDFPlugin::handleContextMenuEvent):
(WebKit::UnifiedPDFPlugin::performContextMenuAction const):

Canonical link: https://commits.webkit.org/271429@main




More information about the webkit-changes mailing list