[webkit-changes] [WebKit/WebKit] c91bcb: [run-webkit-tests] Avoid generating then deleting ...

[Sam Sneddon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c91bcbda38e9cd8f6eb699d6c602782603610eaa
      https://github.com/WebKit/WebKit/commit/c91bcbda38e9cd8f6eb699d6c602782603610eaa
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
    M Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
    R Tools/Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py
    M Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py
    M Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py
    M Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py

  Log Message:
  -----------
  [run-webkit-tests] Avoid generating then deleting several JSON files
https://bugs.webkit.org/show_bug.cgi?id=265553

Reviewed by Jonathan Bedard.

webkitpy.layout_tests.controllers.manager ends up creating both
incremental_results.json and times_ms.json just to immediately delete
them. We should simplify our code by simply not generating them.

Now not generating them, we can delete a lot of now dead code.

* Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._save_json_files):
* Tools/Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Removed.
* Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(write_json):
(add_path_to_trie):
(_add_perf_metric_for_test):
(perf_metrics_for_test):
(convert_trie_to_flat_paths): Deleted.
(test_timings_trie): Deleted.
(TestResult): Deleted.
(TestResult.__init__): Deleted.
(TestResult.fixable): Deleted.
(JSONResultsGenerator): Deleted.
(JSONResultsGenerator.__init__): Deleted.
(JSONResultsGenerator.generate_json_output): Deleted.
(JSONResultsGenerator.generate_times_ms_file): Deleted.
(JSONResultsGenerator.get_json): Deleted.
(JSONResultsGenerator.set_archived_results): Deleted.
(JSONResultsGenerator._get_test_timing): Deleted.
(JSONResultsGenerator._get_failed_test_names): Deleted.
(JSONResultsGenerator._get_modifier_char): Deleted.
(JSONResultsGenerator._get_result_char): Deleted.
(JSONResultsGenerator._insert_failure_summaries): Deleted.
(JSONResultsGenerator._insert_item_into_raw_list): Deleted.
(JSONResultsGenerator._insert_item_run_length_encoded): Deleted.
(JSONResultsGenerator._insert_test_time_and_result): Deleted.
(JSONResultsGenerator._populate_results_and_times_json): Deleted.
(JSONResultsGenerator._create_results_for_builder_json): Deleted.
* Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
(JSONGeneratorTest.test_strip_json_wrapper):
(JSONGeneratorTest.test_perf_metrics_for_test):
(JSONGeneratorTest._test_json_generation): Deleted.
(JSONGeneratorTest._verify_json_results): Deleted.
(JSONGeneratorTest._find_test_in_trie): Deleted.
(JSONGeneratorTest.test_json_generation): Deleted.
(JSONGeneratorTest.test_hierarchical_json_generation): Deleted.
(JSONGeneratorTest.test_test_timings_trie): Deleted.
* Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):

Canonical link: https://commits.webkit.org/271409@main