[webkit-changes] [WebKit/WebKit] e810cd: [UnifiedPDF] Implement snapshotting

Tim Horton noreply at github.com
Fri Dec 1 12:20:28 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e810cde0dcadb06b50af157ea3486eb36bfa7d46
      https://github.com/WebKit/WebKit/commit/e810cde0dcadb06b50af157ea3486eb36bfa7d46
  Author: Tim Horton <timothy_horton at apple.com>
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PluginView.cpp

  Log Message:
  -----------
  [UnifiedPDF] Implement snapshotting
https://bugs.webkit.org/show_bug.cgi?id=265630
<rdar://problem/118550690>

Reviewed by Richard Robinson.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
(WebKit::PDFPluginBase::shouldCreateTransientPaintingSnapshot const):
(WebKit::PDFPluginBase::snapshot):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::paint):
(WebKit::UnifiedPDFPlugin::snapshot): Deleted.
* Source/WebKit/WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::shouldCreateTransientPaintingSnapshot const):
Implement paint() in terms of paintContents() and disable the unnecessary
indirection of PDFPlugin's ShareableBitmap snapshotting for UnifiedPDFPlugin.

paint() is only called during snapshotting.

Canonical link: https://commits.webkit.org/271403@main




More information about the webkit-changes mailing list