[webkit-changes] [WebKit/WebKit] 0adc9c: Move some window functions from WebProcessProxy to...

Charlie Wolfe noreply at github.com
Fri Dec 1 11:59:32 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0adc9c766fb1391a789d379cfbf86bc13a1a3d19
      https://github.com/WebKit/WebKit/commit/0adc9c766fb1391a789d379cfbf86bc13a1a3d19
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
    M Source/WebKit/UIProcess/RemotePageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.messages.in
    M Source/WebKit/UIProcess/WebProcessProxy.cpp
    M Source/WebKit/UIProcess/WebProcessProxy.h
    M Source/WebKit/UIProcess/WebProcessProxy.messages.in
    M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
    M Source/WebKit/WebProcess/WebProcess.cpp
    M Source/WebKit/WebProcess/WebProcess.h
    M Source/WebKit/WebProcess/WebProcess.messages.in

  Log Message:
  -----------
  Move some window functions from WebProcessProxy to WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=265608
rdar://119003812

Reviewed by Alex Christensen.

To resolve 'FIXME: This, postMessageToRemote, renderTreeAsText, etc. should be messages to the
WebPageProxy instead of the process. They are more the page doing things than the process.'

* Source/WebKit/UIProcess/RemotePageProxy.h:
(WebKit::RemotePageProxy::sendSync):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sendToWebPage):
(WebKit::WebPageProxy::sendSyncToProcessContainingFrame):
I added helper functions to support sending synchronous IPC messages to a process containing a
specified frame.

(WebKit::WebPageProxy::closeRemoteFrame):
(WebKit::WebPageProxy::focusRemoteFrame):
(WebKit::WebPageProxy::postMessageToRemote):
(WebKit::WebPageProxy::renderTreeAsText):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::postMessageToRemote): Deleted.
(WebKit::WebProcessProxy::closeRemoteFrame): Deleted.
(WebKit::WebProcessProxy::focusRemoteFrame): Deleted.
(WebKit::WebProcessProxy::renderTreeAsText): Deleted.
* Source/WebKit/UIProcess/WebProcessProxy.h:
* Source/WebKit/UIProcess/WebProcessProxy.messages.in:
* Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp:
(WebKit::WebRemoteFrameClient::postMessageToRemote):
(WebKit::WebRemoteFrameClient::renderTreeAsText):
(WebKit::WebRemoteFrameClient::close):
(WebKit::WebRemoteFrameClient::focus):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveSyncMessage):
(WebKit::WebPage::remotePostMessage):
(WebKit::WebPage::renderTreeAsText):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveSyncMessage):
(WebKit::WebProcess::remotePostMessage): Deleted.
(WebKit::WebProcess::renderTreeAsText): Deleted.
* Source/WebKit/WebProcess/WebProcess.h:
This change removed the remaining synchronous IPC messages going to `WebProcess`. As a result, the
`didReceiveSyncWebProcessMessage()` function declaration was no longer generated.

* Source/WebKit/WebProcess/WebProcess.messages.in:

Canonical link: https://commits.webkit.org/271401@main




More information about the webkit-changes mailing list