[webkit-changes] [WebKit/WebKit] 95e0aa: [scroll-animations] `ViewTimeline` should be a sub...

Antoine Quint noreply at github.com
Fri Dec 1 11:02:30 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 95e0aa587869fa4b2b26a192f645769761e1afa1
      https://github.com/WebKit/WebKit/commit/95e0aa587869fa4b2b26a192f645769761e1afa1
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/unattached-subject-inset-expected.txt
    M Source/WebCore/animation/ScrollTimeline.h
    M Source/WebCore/animation/ViewTimeline.cpp
    M Source/WebCore/animation/ViewTimeline.h
    M Source/WebCore/animation/ViewTimeline.idl

  Log Message:
  -----------
  [scroll-animations] `ViewTimeline` should be a subclass of `ScrollTimeline`
https://bugs.webkit.org/show_bug.cgi?id=265668

Reviewed by Dean Jackson.

When we added `ViewTimeline` in bug 264411 we overlooked how in the spec it was specified as
a `ScrollTimeline` subclass. We now fix this and remove the ScrollAxis member in `ViewTimeline`
since it exists already on `ScrollTimeline`.

* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/view-timelines/unattached-subject-inset-expected.txt:
* Source/WebCore/animation/ScrollTimeline.h:
(WebCore::ScrollTimeline::ScrollTimeline):
* Source/WebCore/animation/ViewTimeline.cpp:
(WebCore::ViewTimeline::ViewTimeline):
* Source/WebCore/animation/ViewTimeline.h:
* Source/WebCore/animation/ViewTimeline.idl:

Canonical link: https://commits.webkit.org/271398@main




More information about the webkit-changes mailing list