[webkit-changes] [WebKit/WebKit] 0143c1: [GStreamer][MSE] media/media-source/media-source-w...

Philippe Normand noreply at github.com
Fri Dec 1 02:17:22 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0143c180fd5aa389275e1e453c35f2b2e33fb559
      https://github.com/WebKit/WebKit/commit/0143c180fd5aa389275e1e453c35f2b2e33fb559
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

  Log Message:
  -----------
  [GStreamer][MSE] media/media-source/media-source-webm-configuration-framerate.html is flaky crash
https://bugs.webkit.org/show_bug.cgi?id=264663

Reviewed by Xabier Rodriguez-Calvar.

Check the m_source GRefPtr is non-null when handling the stream-collection message. It might be
cleared while the player is getting disposed. The whole method cannot be called from a WeakPtr
player without causing deadlocks, sadly.

* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleStreamCollectionMessage):

Canonical link: https://commits.webkit.org/271374@main




More information about the webkit-changes mailing list