[webkit-changes] [WebKit/WebKit] 1b8732: [JSC] Use MonotonicTime for SamplingProfiler JSON ...

Yusuke Suzuki noreply at github.com
Thu Aug 31 15:56:36 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1b8732286c537bc76aac6dd482134c7029aefbf8
      https://github.com/WebKit/WebKit/commit/1b8732286c537bc76aac6dd482134c7029aefbf8
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-08-31 (Thu, 31 Aug 2023)

  Changed paths:
    M Source/JavaScriptCore/inspector/agents/InspectorScriptProfilerAgent.cpp
    M Source/JavaScriptCore/runtime/SamplingProfiler.cpp
    M Source/JavaScriptCore/runtime/SamplingProfiler.h
    M Source/WTF/wtf/Stopwatch.h

  Log Message:
  -----------
  [JSC] Use MonotonicTime for SamplingProfiler JSON dump timestamp
https://bugs.webkit.org/show_bug.cgi?id=260998
rdar://114791556

Reviewed by Justin Michaud.

Replace timestamp of SamplingProfiler JSON dump from Stopwatch's elapsedTime
to MonotonicTime to easily sync it with the system wide samples.

* Source/JavaScriptCore/inspector/agents/InspectorScriptProfilerAgent.cpp:
(Inspector::buildSamples):
(Inspector::InspectorScriptProfilerAgent::trackingComplete):
* Source/JavaScriptCore/runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::timerLoop):
(JSC::SamplingProfiler::takeSample):
(JSC::SamplingProfiler::processUnverifiedStackTraces):
(JSC::SamplingProfiler::noticeVMEntry):
(JSC::SamplingProfiler::stackTracesAsJSON):
* Source/JavaScriptCore/runtime/SamplingProfiler.h:
* Source/WTF/wtf/Stopwatch.h:
(WTF::Stopwatch::elapsedTime const):
(WTF::Stopwatch::elapsedTimeAndTimestamp const):
(WTF::Stopwatch::create): Deleted.
(WTF::Stopwatch::isActive const): Deleted.
(WTF::Stopwatch::Stopwatch): Deleted.

Canonical link: https://commits.webkit.org/267527@main




More information about the webkit-changes mailing list