[webkit-changes] [WebKit/WebKit] f6b1fa: Use generator to set CMAKE_EXPORT_COMPILE_COMMANDS

[Don Olmstead]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f6b1fa7647c7e2b2f4eefbb45c79dbd27d5479ab
      https://github.com/WebKit/WebKit/commit/f6b1fa7647c7e2b2f4eefbb45c79dbd27d5479ab
  Author: Don Olmstead <don.olmstead at sony.com>
  Date:   2023-08-31 (Thu, 31 Aug 2023)

  Changed paths:
    M Source/cmake/WebKitCommon.cmake
    M Tools/Scripts/webkitdirs.pm

  Log Message:
  -----------
  Use generator to set CMAKE_EXPORT_COMPILE_COMMANDS
https://bugs.webkit.org/show_bug.cgi?id=260666

Reviewed by Michael Catanzaro.

In 266947 at main a target `RewriteCompileCommands` was added for unified
builds where `CMAKE_EXPORT_COMPILE_COMMANDS` is `ON`. However this
is only valid for Makefile and Ninja generators. On Visual Studio it
is ignored so the target will always fail to build which was found out
because its always set to `ON` within `build-webkit`.

Move the logic for turning it `ON` into the CMake code and base it on
the `CMAKE_GENERATOR`.

* Source/cmake/WebKitCommon.cmake
* Tools/Scripts/webkitdirs.pm

Canonical link: https://commits.webkit.org/267521@main