[webkit-changes] [WebKit/WebKit] c379c0: Cleanup code for shorthand parsing and font-varian...

Tim Nguyen noreply at github.com
Thu Aug 31 14:03:41 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c379c056f604bb93b731e512c76d7011dca13096
      https://github.com/WebKit/WebKit/commit/c379c056f604bb93b731e512c76d7011dca13096
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-08-31 (Thu, 31 Aug 2023)

  Changed paths:
    M Source/WebCore/css/ComputedStyleExtractor.cpp
    M Source/WebCore/css/parser/CSSPropertyParser.cpp

  Log Message:
  -----------
  Cleanup code for shorthand parsing and font-variant computed style
https://bugs.webkit.org/show_bug.cgi?id=260985
rdar://114780529

Reviewed by Myles C. Maxfield.

* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle const):
(WebCore::fontVariantPositionPropertyValue): Deleted.
(WebCore::fontVariantCapsPropertyValue): Deleted.

The toCSSValueID methods in CSSPrimitiveValueMappings.h allow us to remove this redundant code.

* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::consumeFontVariantShorthand):
(WebCore::CSSPropertyParser::consumeListStyleShorthand):

This is consistent with style used for the columns property.

Canonical link: https://commits.webkit.org/267518@main




More information about the webkit-changes mailing list