[webkit-changes] [WebKit/WebKit] 7d6cd5: [GStreamer] Video not resized with playbin3 on i.M...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7d6cd5e4b26870a15004fe75d6d163bdd3539a0d
      https://github.com/WebKit/WebKit/commit/7d6cd5e4b26870a15004fe75d6d163bdd3539a0d
  Author: Marek Vasut <marex at denx.de>
  Date:   2023-08-31 (Thu, 31 Aug 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

  Log Message:
  -----------
  [GStreamer] Video not resized with playbin3 on i.MX8M Plus and COG
https://bugs.webkit.org/show_bug.cgi?id=260482

Reviewed by Philippe Normand.

When using WEBKIT_GST_USE_PLAYBIN3=1 and cog to open h264 video (e.g.
Big Buck Bunny h264 1920x1080 mp4), then only single message is delivered
to MediaPlayerPrivateGStreamer::handleStreamCollectionMessage() . The
current workaround check would bail out since the message source is
decodebin3, while the m_source is filesrc . This prevents player->updateTracks
from being called, and thus m_hasVideo from being set, and thus
hasVideo() in MediaPlayerPrivateGStreamer::naturalSize() returns false
and MediaPlayerPrivateGStreamer::naturalSize returns FloatSize()
size, which is 0x0. The resulting video element in the browser has
minimum height set and is not correctly resized.

Limit the MediaPlayerPrivateGStreamer::handleStreamCollectionMessage()
workaround only to non-filesrc, since filesrc is not generating the
stream-collection events.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleStreamCollectionMessage):

Canonical link: https://commits.webkit.org/267515@main