[webkit-changes] [WebKit/WebKit] 416515: [Cocoa] VideoFullscreenInterfaceContext::m_manager...

aestes noreply at github.com
Thu Aug 31 09:45:32 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4165157020d8e4b60062b5d144279c06b8c6c0ab
      https://github.com/WebKit/WebKit/commit/4165157020d8e4b60062b5d144279c06b8c6c0ab
  Author: Andy Estes <aestes at apple.com>
  Date:   2023-08-31 (Thu, 31 Aug 2023)

  Changed paths:
    M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h
    M Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm

  Log Message:
  -----------
  [Cocoa] VideoFullscreenInterfaceContext::m_manager should be a WeakPtr
https://bugs.webkit.org/show_bug.cgi?id=260873
rdar://114654278

Reviewed by Jer Noble.

Changed VideoFullscreenInterfaceContext::m_manager from a VideoFullscreenManager* to a
WeakPtr<VideoFullscreenManager>.

* Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h:
(WebKit::VideoFullscreenInterfaceContext::invalidate): Deleted.
* Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm:
(WebKit::VideoFullscreenInterfaceContext::VideoFullscreenInterfaceContext):
(WebKit::VideoFullscreenManager::~VideoFullscreenManager):
(WebKit::VideoFullscreenManager::removeContext):

Canonical link: https://commits.webkit.org/267505@main




More information about the webkit-changes mailing list