[webkit-changes] [WebKit/WebKit] 1a2b1a: [IFC] Do not try to measure text content across In...

Alan Baradlay noreply at github.com
Thu Aug 31 06:41:50 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1a2b1a5111fec39251c05deff1f97ae9d5849354
      https://github.com/WebKit/WebKit/commit/1a2b1a5111fec39251c05deff1f97ae9d5849354
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-08-31 (Thu, 31 Aug 2023)

  Changed paths:
    A LayoutTests/fast/text/complex-text-with-bidi-boundary-crash-expected.txt
    A LayoutTests/fast/text/complex-text-with-bidi-boundary-crash.html
    M Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp
    M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp

  Log Message:
  -----------
  [IFC] Do not try to measure text content across InlineItems
https://bugs.webkit.org/show_bug.cgi?id=260935
<rdar://114696241>

Reviewed by Antti Koivisto.

This happens when ubidi_getLogicalRun makes us split inside a cluster (bug?) producing multiple InlineItems.

(simplifiedMinimumInstrinsicWidthBreak extra check is added to mirror what we already do at the slow codepath)

* LayoutTests/fast/text/complex-text-with-bidi-boundary-crash-expected.txt: Added.
* LayoutTests/fast/text/complex-text-with-bidi-boundary-crash.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.cpp:
(WebCore::Layout::InlineContentBreaker::simplifiedMinimumInstrinsicWidthBreak const):
* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::TextUtil::firstUserPerceivedCharacterLength):

Canonical link: https://commits.webkit.org/267495@main




More information about the webkit-changes mailing list