[webkit-changes] [WebKit/WebKit] aed2f1: Don’t open “details” when interacting with interac...

[sideshowbarker]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aed2f1dba4a42f57914f579efc8f76b7c9fe8f3e
      https://github.com/WebKit/WebKit/commit/aed2f1dba4a42f57914f579efc8f76b7c9fe8f3e
  Author: Michael[tm] Smith <mike at w3.org>
  Date:   2023-08-31 (Thu, 31 Aug 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/anchor-with-inline-element-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/interactive-content-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/interactive-content.html
    M Source/WebCore/html/HTMLSummaryElement.cpp

  Log Message:
  -----------
  Don’t open “details” when interacting with interactive “summary” descendants
https://bugs.webkit.org/show_bug.cgi?id=218758

Reviewed by Tim Nguyen.

This change ensures that interacting with (clicking/pressing/etc.) any
interactive descendants of a “summary” element will trigger the
activation behavior of those descendants themselves — rather than
instead triggering the “summary” element’s “details” parent to open.

Otherwise, without this change, the activation behavior of interactive
content within a “summary” element will get triggered only if that
interactive content is a direct child of the “summary” element.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/anchor-with-inline-element-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/interactive-content-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-summary-element/interactive-content.html: Added.
* Source/WebCore/html/HTMLSummaryElement.cpp:
(WebCore::isInSummaryInteractiveContent):
(WebCore::HTMLSummaryElement::defaultEventHandler):
(WebCore::isClickableControl): Deleted.

Canonical link: https://commits.webkit.org/267491@main