[webkit-changes] [WebKit/WebKit] acfa97: [motion-path] Check if we are mid layout when sett...

Nikos Mouchtaris noreply at github.com
Wed Aug 30 19:11:10 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: acfa97d238a39af164eaf24a0abd4eec0cf096b4
      https://github.com/WebKit/WebKit/commit/acfa97d238a39af164eaf24a0abd4eec0cf096b4
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2023-08-30 (Wed, 30 Aug 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-019.html
    A LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-020-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-020.html
    A LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-021-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-021.html
    A LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-022-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-022.html
    M Source/WebCore/page/LocalFrameViewLayoutContext.cpp
    M Source/WebCore/page/LocalFrameViewLayoutContext.h
    M Source/WebCore/rendering/RenderBlock.cpp
    M Source/WebCore/rendering/RenderBlock.h
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp
    M Source/WebCore/rendering/RenderFlexibleBox.cpp
    M Source/WebCore/rendering/RenderGrid.cpp
    M Source/WebCore/rendering/RenderLayerModelObject.cpp

  Log Message:
  -----------
  [motion-path] Check if we are mid layout when setting containing block rect for ray
https://bugs.webkit.org/show_bug.cgi?id=260110
rdar://113780201

Reviewed by Simon Fraser.

On the first RenderLayer::updateTransform call the parent is mid layout, so it is
inorrect to query it about its rect size. If we have a motion path transform, set
that this RenderObject needs a transform update on the parent through the FrameView's
layout context, and have the parent call updateTransform after it has completed layout.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-019-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-019.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-020-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-020.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-021-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-021.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-022-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-022.html: Added.

Canonical link: https://commits.webkit.org/267479@main




More information about the webkit-changes mailing list