[webkit-changes] [WebKit/WebKit] 4cde64: Obscured input fields are not obscured in the keyb...

megangardner noreply at github.com
Tue Aug 29 17:39:40 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4cde644bbab2419c9590436ba32925208bb90aa6
      https://github.com/WebKit/WebKit/commit/4cde644bbab2419c9590436ba32925208bb90aa6
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2023-08-29 (Tue, 29 Aug 2023)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

  Log Message:
  -----------
  Obscured input fields are not obscured in the keyboard on visionOS.
https://bugs.webkit.org/show_bug.cgi?id=260838
rdar://113924534

Reviewed by Wenson Hsieh.

We need to look at the flag that is set on input fields that indicates that
they are obscured and use that information to determine if we should
emit all the of text. We started emitting text in
https://github.com/WebKit/WebKit/commit/e1c274e43bdde86eea8fdd34ccc7789fdc279511
so that we would show password in the keyboard field on visionOS,
but if the isAutoFilledAndObscured flag is set, we do not want to display
that information in the keyboard. We look at the start and end of the selected range,
and if either one is in an obscured input field, we do not emit all text.

* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::requestDocumentEditingContext):

Canonical link: https://commits.webkit.org/267436@main




More information about the webkit-changes mailing list