[webkit-changes] [WebKit/WebKit] 8b0014: m_has*EventListener does not have to be atomic

Sihui noreply at github.com
Mon Aug 28 20:10:57 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b00141fa9f08379230c571f81cf57bb1b9617ad
      https://github.com/WebKit/WebKit/commit/8b00141fa9f08379230c571f81cf57bb1b9617ad
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2023-08-28 (Mon, 28 Aug 2023)

  Changed paths:
    M Source/WebCore/Modules/cookie-store/CookieStore.h
    M Source/WebCore/Modules/permissions/PermissionStatus.h
    M Source/WebCore/xml/XMLHttpRequest.h

  Log Message:
  -----------
  m_has*EventListener does not have to be atomic
https://bugs.webkit.org/show_bug.cgi?id=260804
rdar://114572793

Reviewed by Ryosuke Niwa and Chris Dumez.

We were using atomic at these places because `virtualHasPendingActivity()` can be called on non-main thread and
`eventListenersDidChange()` is invoked on main thread. However, `virtualHasPendingActivity()` is called on non-main
thread only when main thread is paused, so there is no need to use atomic.

* Source/WebCore/Modules/cookie-store/CookieStore.h:
* Source/WebCore/Modules/permissions/PermissionStatus.h:
* Source/WebCore/xml/XMLHttpRequest.h:

Canonical link: https://commits.webkit.org/267387@main




More information about the webkit-changes mailing list