[webkit-changes] [WebKit/WebKit] 4bd7a7: REGRESSION(267111 at main): Safari crash when tapping...

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4bd7a7653518138ff4d2784ea6e57a725daf4e11
      https://github.com/WebKit/WebKit/commit/4bd7a7653518138ff4d2784ea6e57a725daf4e11
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2023-08-28 (Mon, 28 Aug 2023)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.mm

  Log Message:
  -----------
  REGRESSION(267111 at main): Safari crash when tapping “allow for one day” Terminating app due to uncaught exception.
https://webkit.org/b/260828
rdar://114581149

Reviewed by Chris Dumez.

The matchesURL: and matchesURL:options: methods should take nil for the URL and always return NO.
This was happening by accident before. Also mark the match methods as taking nullable URLs and patterns.

* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.mm:
(-[_WKWebExtensionMatchPattern matchesURL:options:]): Return early if the URL is nil.

Canonical link: https://commits.webkit.org/267373@main