[webkit-changes] [WebKit/WebKit] 7378cf: AX: dialog-showModal fails in ITM

Joshua Hoffman noreply at github.com
Mon Aug 28 10:52:27 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7378cf3a2fd2c653477f6d58d9fdbbe4a3e1216a
      https://github.com/WebKit/WebKit/commit/7378cf3a2fd2c653477f6d58d9fdbbe4a3e1216a
  Author: hoffmanjoshua <jhoffman23 at apple.com>
  Date:   2023-08-28 (Mon, 28 Aug 2023)

  Changed paths:
    M LayoutTests/accessibility-isolated-tree/TestExpectations
    M LayoutTests/accessibility/dialog-showModal-expected.txt
    M LayoutTests/accessibility/dialog-showModal.html

  Log Message:
  -----------
  AX: dialog-showModal fails in ITM
https://bugs.webkit.org/show_bug.cgi?id=260727
rdar://problem/114463793

Reviewed by Chris Fleizach.

This fixes accessibility/dialog-showModal.html in isolated tree mode by waiting for async updates to the "ok"
button before querying. The test was also modified to follow updated patterns in test outputs.

* LayoutTests/accessibility/dialog-showModal.html:
* LayoutTests/accessibility/dialog-showModal-expected.txt:

Changes dialog-ShowModal to wait for the ok button to update asynchronously. Also replaced debug() and
description() usage with concatenating output string pattern.

Canonical link: https://commits.webkit.org/267357@main




More information about the webkit-changes mailing list