[webkit-changes] [WebKit/WebKit] 6cabcd: Use BinaryType for RTCDataChannel

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6cabcd45af4dce6a46dc35330fa12a0aa078cab5
      https://github.com/WebKit/WebKit/commit/6cabcd45af4dce6a46dc35330fa12a0aa078cab5
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-08-28 (Mon, 28 Aug 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCDataChannel-binaryType.window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCDataChannel-binaryType.window.js
    M Source/WebCore/Modules/mediastream/RTCDataChannel.cpp
    M Source/WebCore/Modules/mediastream/RTCDataChannel.h
    M Source/WebCore/Modules/mediastream/RTCDataChannel.idl
    M Source/WebCore/Modules/websockets/WebSocket.cpp
    M Source/WebCore/Modules/websockets/WebSocket.h

  Log Message:
  -----------
  Use BinaryType for RTCDataChannel
https://bugs.webkit.org/show_bug.cgi?id=260790
rdar://114559008

Reviewed by Youenn Fablet.

Aligns RTCDataChannel with its specification (and WebSocket). Also
address some nits in our WebSocket setBinaryType() implementation.

This largely matches Gecko. (Chromium does not appear to implement
this.) Gecko and the specification still have a different default
value.

Updated tests are upstreamed via
https://github.com/web-platform-tests/wpt/pull/41663.

* LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCDataChannel-binaryType.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCDataChannel-binaryType.window.js:
(test):
(const.binaryType.of.invalidBinaryTypes.test):
* Source/WebCore/Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::setBinaryType):
(WebCore::RTCDataChannel::didReceiveRawData):
(WebCore::blobKeyword): Deleted.
(WebCore::arraybufferKeyword): Deleted.
(WebCore::RTCDataChannel::binaryType const): Deleted.
* Source/WebCore/Modules/mediastream/RTCDataChannel.h:
* Source/WebCore/Modules/mediastream/RTCDataChannel.idl:
* Source/WebCore/Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::setBinaryType):
* Source/WebCore/Modules/websockets/WebSocket.h:

Canonical link: https://commits.webkit.org/267353@main