[webkit-changes] [WebKit/WebKit] 37bc74: [GStreamer] Prevent a crash when fetching data on ...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 37bc7427407685a224044ddc3df4b81c41d6fd38
      https://github.com/WebKit/WebKit/commit/37bc7427407685a224044ddc3df4b81c41d6fd38
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-08-28 (Mon, 28 Aug 2023)

  Changed paths:
    A LayoutTests/http/wpt/mediarecorder/MediaRecorder-start-stop-crash.html
    M Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.h
    M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp
    M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.h

  Log Message:
  -----------
  [GStreamer] Prevent a crash when fetching data on stopped MediaRecorder
https://bugs.webkit.org/show_bug.cgi?id=260649
rdar://problem/114370120

Reviewed by Xabier Rodriguez-Calvar.

The backend (GStreamer transcoder) is now clearly separated from the MediaRecorderPrivate, so that
fetchData() can create a weak pointer to be used from the main thread. If the backend was destroyed
in-flight no unsafe memory access is performed.

Test: http/wpt/mediarecorder/MediaRecorder-start-stop-crash.html
Canonical link: https://commits.webkit.org/267345@main