[webkit-changes] [WebKit/WebKit] 67c98f: Allow fontForCombiningCharacterSequence() and canR...

[Myles C. Maxfield]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 67c98f07295d7d27c34f307816941ec726a96c73
      https://github.com/WebKit/WebKit/commit/67c98f07295d7d27c34f307816941ec726a96c73
  Author: Myles C. Maxfield <mmaxfield at apple.com>
  Date:   2023-08-25 (Fri, 25 Aug 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/ComplexTextController.cpp
    M Source/WebCore/platform/graphics/Font.cpp
    M Source/WebCore/platform/graphics/Font.h
    M Source/WebCore/platform/graphics/FontCascade.cpp
    M Source/WebCore/platform/graphics/FontCascade.h
    M Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp
    M Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp

  Log Message:
  -----------
  Allow fontForCombiningCharacterSequence() and canRenderCombiningCharacterSequence() to be able to accept 8-bit characters
https://bugs.webkit.org/show_bug.cgi?id=260753
rdar://114478724

Reviewed by Cameron McCormack.

If we're going to make the fast text codepath powerful enough to handle complex
text, that means it's going to have to call fontForCombiningCharacterSequence()
and canRenderCombiningCharacterSequence(). The fast text codepath is templated
to accept either 8-bit characters or 16-bit characters, which means anything
it calls must be able to do so as well.

There's no behavior change with just this patch - these functions are still only
being called with 16-bit characters. This patch just changes the type of them
so they could be called with 8-bit characters in the future. (So, there are no
tests in this patch.)

* Source/WebCore/platform/graphics/ComplexTextController.cpp:
(WebCore::ComplexTextController::collectComplexTextRuns):
* Source/WebCore/platform/graphics/Font.cpp:
(WebCore::Font::canRenderCombiningCharacterSequence const):
* Source/WebCore/platform/graphics/Font.h:
* Source/WebCore/platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::fontForCombiningCharacterSequence const):
* Source/WebCore/platform/graphics/FontCascade.h:
* Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp:
(WebCore::FontCascade::fontForCombiningCharacterSequence const):

Canonical link: https://commits.webkit.org/267317@main