[webkit-changes] [WebKit/WebKit] 9b124c: Placate exception check validation in sanitizeRemo...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9b124cc4e156b686d5eebafff5bb479f083d7df7
      https://github.com/WebKit/WebKit/commit/9b124cc4e156b686d5eebafff5bb479f083d7df7
  Author: Mark Lam <mark.lam at apple.com>
  Date:   2023-08-25 (Fri, 25 Aug 2023)

  Changed paths:
    M Source/JavaScriptCore/interpreter/Interpreter.cpp

  Log Message:
  -----------
  Placate exception check validation in sanitizeRemoteFunctionException.
https://bugs.webkit.org/show_bug.cgi?id=260750
rdar://114477714

Reviewed by Justin Michaud.

sanitizeRemoteFunctionException() can call JSValue::toWTFString() which may throw under certain
circumstances.  However, it is only called here if exceptionValue.isPrimitive() i.e. it will
never throw.  However, the exception check validator does not know this.  So, we added an
`ASSERT(!scope.exception())` to placate it.

However, if we're forcing exception check validation on a Release build, the ASSERT turns into a
no-op.  The fix is to use EXCEPTION_ASSERT here instead.

* Source/JavaScriptCore/interpreter/Interpreter.cpp:
(JSC::sanitizeRemoteFunctionException):

Canonical link: https://commits.webkit.org/267311@main