[webkit-changes] [WebKit/WebKit] 12ec99: Suppress HeapSnapshot logging in some JSC stress t...

Commit Queue noreply at github.com
Fri Aug 25 16:56:15 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 12ec99a12155a439d026d768a68a4be3f5f61de2
      https://github.com/WebKit/WebKit/commit/12ec99a12155a439d026d768a68a4be3f5f61de2
  Author: Mark Lam <mark.lam at apple.com>
  Date:   2023-08-25 (Fri, 25 Aug 2023)

  Changed paths:
    M JSTests/stress/collect-continuously-should-not-wake-concurrent-collector-after-prevent-collection-is-called.js
    M JSTests/stress/heap-analyzer-taking-lock.js
    M Source/JavaScriptCore/heap/HeapSnapshotBuilder.cpp
    M Source/JavaScriptCore/runtime/OptionsList.h

  Log Message:
  -----------
  Suppress HeapSnapshot logging in some JSC stress tests.
https://bugs.webkit.org/show_bug.cgi?id=260743
rdar://114474559

Reviewed by Justin Michaud.

Specifically, heap-analyzer-taking-lock.js and collect-continuously-should-not-wake-concurrent-collector-after-prevent-collection-is-called.js.
The logging is not needed for the tests, and the verbosity of the logging makes it hard to see real failures when running the JSC stress tests.

* JSTests/stress/collect-continuously-should-not-wake-concurrent-collector-after-prevent-collection-is-called.js:
* JSTests/stress/heap-analyzer-taking-lock.js:
* Source/JavaScriptCore/heap/HeapSnapshotBuilder.cpp:
(JSC::HeapSnapshotBuilder::analyzeEdge):
(JSC::HeapSnapshotBuilder::json):
* Source/JavaScriptCore/runtime/OptionsList.h:

Canonical link: https://commits.webkit.org/267306@main




More information about the webkit-changes mailing list