[webkit-changes] [WebKit/WebKit] c0b02e: RETURN_IF_EXCEPTION should work for Release builds...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c0b02e6b685b641501af69ff3b4990db1a3bef2e
      https://github.com/WebKit/WebKit/commit/c0b02e6b685b641501af69ff3b4990db1a3bef2e
  Author: Mark Lam <mark.lam at apple.com>
  Date:   2023-08-25 (Fri, 25 Aug 2023)

  Changed paths:
    M Source/JavaScriptCore/runtime/ExceptionScope.h

  Log Message:
  -----------
  RETURN_IF_EXCEPTION should work for Release builds too.
https://bugs.webkit.org/show_bug.cgi?id=260745
rdar://114475322

Reviewed by Justin Michaud.

In PlatformEnable.h, we can force ENABLE_EXCEPTION_SCOPE_VERIFICATION to be on so that we can
validate exception checks with a Release build.  However, RETURN_IF_EXCEPTION is relying on an
ASSERT to tickle the exception check validator, and ASSERTs are no-ops on Release builds.

The right thing to do is to use EXCEPTION_ASSERT instead.  This patch applies this fix.

* Source/JavaScriptCore/runtime/ExceptionScope.h:

Canonical link: https://commits.webkit.org/267303@main