[webkit-changes] [WebKit/WebKit] 91a139: IPC tests should be certain async messages have be...

[Gavin]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 91a139dc0c8e28d9a86d5479a3bb1f463dc4bd67
      https://github.com/WebKit/WebKit/commit/91a139dc0c8e28d9a86d5479a3bb1f463dc4bd67
  Author: Gavin Phillips <gavin.p at apple.com>
  Date:   2023-08-25 (Fri, 25 Aug 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/ipc/restrictedendpoints/allow-access-attachmentElement.html
    M LayoutTests/ipc/restrictedendpoints/allow-access-modelElement.html
    A LayoutTests/ipc/restrictedendpoints/allow-access-testOnlyIPC-expected.txt
    A LayoutTests/ipc/restrictedendpoints/allow-access-testOnlyIPC.html
    M LayoutTests/ipc/restrictedendpoints/allow-access-webGPU.html
    M LayoutTests/ipc/restrictedendpoints/deny-access-attachmentElement.html
    M LayoutTests/ipc/restrictedendpoints/deny-access-modelElement.html
    A LayoutTests/ipc/restrictedendpoints/deny-access-testOnlyIPC-expected.txt
    A LayoutTests/ipc/restrictedendpoints/deny-access-testOnlyIPC.html
    M LayoutTests/ipc/restrictedendpoints/deny-access-updateQuotaBasedOnSpaceUsageForTesting-expected.txt
    M LayoutTests/ipc/restrictedendpoints/deny-access-updateQuotaBasedOnSpaceUsageForTesting.html
    M LayoutTests/ipc/restrictedendpoints/deny-access-webGPU.html
    M LayoutTests/ipc/restrictedendpoints/deny-access-webPush.html
    R LayoutTests/ipc/restrictedendpoints/no-test-only-ipc-expected-crash-expected.txt
    R LayoutTests/ipc/restrictedendpoints/no-test-only-ipc-expected-crash.html
    R LayoutTests/ipc/restrictedendpoints/test-only-ipc-allowed-expected.txt
    R LayoutTests/ipc/restrictedendpoints/test-only-ipc-allowed.html
    M LayoutTests/platform/mac-wk1/TestExpectations
    M LayoutTests/platform/mac-wk2/TestExpectations
    M LayoutTests/platform/wk2/TestExpectations
    A LayoutTests/resources/ipc.js
    M Source/WebKit/Shared/IPCTester.cpp
    M Source/WebKit/Shared/IPCTester.h
    M Source/WebKit/Shared/IPCTester.messages.in

  Log Message:
  -----------
  IPC tests should be certain async messages have been processed prior to marking the test as complete
https://bugs.webkit.org/show_bug.cgi?id=260610
rdar://114321513

Reviewed by Alex Christensen.

This change introduces asyncFlush and syncFlush routines which can be
used in IPC tests to confirm that any prior messages have been fully processed.
This is then adopted into the existing restrictedendpoints IPC tests.

* LayoutTests/TestExpectations:
* LayoutTests/ipc/restrictedendpoints/allow-access-attachmentElement.html:
* LayoutTests/ipc/restrictedendpoints/allow-access-modelElement.html:
* LayoutTests/ipc/restrictedendpoints/allow-access-testOnlyIPC-expected.txt: Copied from LayoutTests/ipc/restrictedendpoints/no-test-only-ipc-expected-crash-expected.txt.
* LayoutTests/ipc/restrictedendpoints/allow-access-testOnlyIPC.html: Added.
* LayoutTests/ipc/restrictedendpoints/allow-access-webGPU.html:
* LayoutTests/ipc/restrictedendpoints/deny-access-attachmentElement.html:
* LayoutTests/ipc/restrictedendpoints/deny-access-modelElement.html:
* LayoutTests/ipc/restrictedendpoints/deny-access-testOnlyIPC-expected.txt: Renamed from LayoutTests/ipc/restrictedendpoints/no-test-only-ipc-expected-crash-expected.txt.
* LayoutTests/ipc/restrictedendpoints/deny-access-testOnlyIPC.html: Added.
* LayoutTests/ipc/restrictedendpoints/deny-access-updateQuotaBasedOnSpaceUsageForTesting-expected.txt:
* LayoutTests/ipc/restrictedendpoints/deny-access-updateQuotaBasedOnSpaceUsageForTesting.html:
* LayoutTests/ipc/restrictedendpoints/deny-access-webGPU.html:
* LayoutTests/ipc/restrictedendpoints/deny-access-webPush.html:
* LayoutTests/ipc/restrictedendpoints/no-test-only-ipc-expected-crash.html: Removed.
* LayoutTests/ipc/restrictedendpoints/test-only-ipc-allowed-expected.txt: Removed.
* LayoutTests/ipc/restrictedendpoints/test-only-ipc-allowed.html: Removed.
* LayoutTests/platform/mac-wk2/TestExpectations:
* LayoutTests/resources/ipc.js: Added.
(asyncFlush):
(syncFlush):
* Source/WebKit/Shared/IPCTester.cpp:
(WebKit::IPCTester::asyncPing):
(WebKit::IPCTester::syncPing):
* Source/WebKit/Shared/IPCTester.h:
* Source/WebKit/Shared/IPCTester.messages.in:

Canonical link: https://commits.webkit.org/267290@main