[webkit-changes] [WebKit/WebKit] 0e2d4a: AX: Move support for non-standard ARIA text role b...

Tyler Wilcock noreply at github.com
Fri Aug 25 10:53:36 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0e2d4af24d5c9f2ce98f2e7c10721b396ca335c3
      https://github.com/WebKit/WebKit/commit/0e2d4af24d5c9f2ce98f2e7c10721b396ca335c3
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2023-08-25 (Fri, 25 Aug 2023)

  Changed paths:
    A LayoutTests/accessibility/text-aria-role-disabled-expected.txt
    A LayoutTests/accessibility/text-aria-role-disabled.html
    A LayoutTests/platform/glib/accessibility/text-aria-role-disabled-expected.txt
    M LayoutTests/platform/ios/TestExpectations
    A LayoutTests/platform/ios/accessibility/text-aria-role-disabled-expected.txt
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp

  Log Message:
  -----------
  AX: Move support for non-standard ARIA text role behind an off-by-default feature flag
https://bugs.webkit.org/show_bug.cgi?id=260684
rdar://problem/114414991

Reviewed by Chris Fleizach.

We want to remove role="text" entirely as it's non-standard. Move it
behind an off-by-default flag for now to give users the option to turn
it back on in case anybody actually uses it.

* LayoutTests/platform/ios/accessibility/text-aria-role-disabled-expected.txt:
Added. Ensures the new default behavior of not supporting role="text"
behaves as expected.
* LayoutTests/platform/ios/TestExpectations:
Enable new test.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
Add new feature flag.
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAriaRoleAttribute const):

Canonical link: https://commits.webkit.org/267285@main




More information about the webkit-changes mailing list