[webkit-changes] [WebKit/WebKit] 4820e6: Use ShorthandSerializer for grid-template shorthand.

Sammy Gill noreply at github.com
Fri Aug 25 07:41:13 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4820e6a9d6603660f37396c83f290b9b44afd92b
      https://github.com/WebKit/WebKit/commit/4820e6a9d6603660f37396c83f290b9b44afd92b
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2023-08-25 (Fri, 25 Aug 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-layout-properties-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssom-getPropertyValue-common-checks-expected.txt
    M Source/WebCore/css/CSSComputedStyleDeclaration.cpp
    M Source/WebCore/css/ShorthandSerializer.cpp
    M Source/WebCore/css/ShorthandSerializer.h

  Log Message:
  -----------
  Use ShorthandSerializer for grid-template shorthand.
https://bugs.webkit.org/show_bug.cgi?id=260397.
rdar://114097919.

Reviewed by Darin Adler.

The ShorthandSerializer already serializes the shorthand into its
shortest representation. When we get the property value for the computed
style, we can use the ShorthandSerializer instead.

In order to do this, the ShorthandSeralizer needs a new constructor that
can take a ComputedStyleExtractor. This will be used in commonSerializationChecks
to set the longhand values appropriately.

* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-layout-properties-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssom-getPropertyValue-common-checks-expected.txt:
* Source/WebCore/css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyValue const):
* Source/WebCore/css/ShorthandSerializer.cpp:
(WebCore::ShorthandSerializer::ShorthandSerializer):
(WebCore::ShorthandSerializer::commonSerializationChecks):
(WebCore::serializeShorthandValue):
* Source/WebCore/css/ShorthandSerializer.h:

Canonical link: https://commits.webkit.org/267280@main




More information about the webkit-changes mailing list