[webkit-changes] [WebKit/WebKit] 277cc3: LibWebRTC TCPConnection might receive packets whil...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 277cc3e4b924b487ff3f17f03bf44bd25a269b05
      https://github.com/WebKit/WebKit/commit/277cc3e4b924b487ff3f17f03bf44bd25a269b05
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-08-25 (Fri, 25 Aug 2023)

  Changed paths:
    M Source/ThirdParty/libwebrtc/Source/webrtc/p2p/base/tcp_port.cc

  Log Message:
  -----------
  LibWebRTC TCPConnection might receive packets while its port is nullptr
https://bugs.webkit.org/show_bug.cgi?id=260705
rdar://113531400

Reviewed by Jean-Yves Avenard.

According logs, we have a nullptr crash in Connection::OnReadPacket when calling Port::GetStunMessage.
The current explanation is this one:
1. The connection is live and connected to the socket (which means it is a TCPConnection).
2. The connection's port is dead, which can happen if Port::DestroyConnectionAsync is called.

To prevent the nullptr crash, we add a nullptr check in TCPConnection::OnReadPacket.

* Source/ThirdParty/libwebrtc/Source/webrtc/p2p/base/tcp_port.cc:

Canonical link: https://commits.webkit.org/267275@main