[webkit-changes] [WebKit/WebKit] 38e8e3: <a>/<area>'s protocol setter incorrectly works for...

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 38e8e38b9f1ffdf05856ae7891c794a9195234aa
      https://github.com/WebKit/WebKit/commit/38e8e38b9f1ffdf05856ae7891c794a9195234aa
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-08-24 (Thu, 24 Aug 2023)

  Changed paths:
    M LayoutTests/imported/w3c/resources/import-expectations.json
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/non-parsable-url-getter-setter.window-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/non-parsable-url-getter-setter.window.html
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/non-parsable-url-getter-setter.window.js
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/non-special-opaque-path-url-getter-setter.window-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/non-special-opaque-path-url-getter-setter.window.html
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/non-special-opaque-path-url-getter-setter.window.js
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/non-special-url-getter-setter.window-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/non-special-url-getter-setter.window.html
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/non-special-url-getter-setter.window.js
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/w3c-import.log
    M Source/WebCore/html/HTMLAnchorElement.cpp
    M Source/WebCore/html/HTMLAnchorElement.h

  Log Message:
  -----------
  <a>/<area>'s protocol setter incorrectly works for non-parsable URLs
https://bugs.webkit.org/show_bug.cgi?id=260653
rdar://114371380

Reviewed by Chris Dumez.

We cannot use URLDecomposition's protocol setter directly as it does
not account for non-parsable URLs (not even indirectly, as most other
getter/setters do). Therefore check for non-parsable URLs in
HTMLAnchorElement before calling it.

New tests are being upstreamed through
https://github.com/web-platform-tests/wpt/pull/41614.

* LayoutTests/imported/w3c/resources/import-expectations.json:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/non-parsable-url-getter-setter.window.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/non-parsable-url-getter-setter.window.js: Added.
(string_appeared_here.forEach.name.get if.set test):
(string_appeared_here.forEach.name.get if):
(forEach.set string_appeared_here):
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/non-special-opaque-path-url-getter-setter.window.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/non-special-opaque-path-url-getter-setter.window.js: Added.
(string_appeared_here.forEach.name.get if.set test):
(string_appeared_here.forEach.name.get if):
(get string_appeared_here):
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/non-special-url-getter-setter.window.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/non-special-url-getter-setter.window.js: Added.
(string_appeared_here.forEach.name.get if.set test):
(string_appeared_here.forEach.name.get if):
(set string_appeared_here):
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/w3c-import.log:
* Source/WebCore/html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::setProtocol):
* Source/WebCore/html/HTMLAnchorElement.h:

Canonical link: https://commits.webkit.org/267265@main