[webkit-changes] [WebKit/WebKit] 0b06db: Container query with font units should invalidate ...

Antti Koivisto noreply at github.com
Thu Aug 24 18:37:11 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0b06dbb375788621d903a2be904c2cf595557d85
      https://github.com/WebKit/WebKit/commit/0b06dbb375788621d903a2be904c2cf595557d85
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-08-24 (Thu, 24 Aug 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/font-relative-calc-dynamic-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/font-relative-units-dynamic-expected.txt
    M Source/WebCore/style/StyleTreeResolver.cpp
    M Source/WebCore/style/StyleTreeResolver.h

  Log Message:
  -----------
  Container query with font units should invalidate when font changes
https://bugs.webkit.org/show_bug.cgi?id=253940
rdar://106739736

Reviewed by Tim Nguyen.

* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/font-relative-calc-dynamic-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/font-relative-units-dynamic-expected.txt:

The remaining failures are units we don't support.

* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::styleChangeAffectsRelativeUnits):

Factor into a function.

(WebCore::Style::TreeResolver::resolveElement):
(WebCore::Style::TreeResolver::updateStateForQueryContainer):

If the container font size changes we need to evaluate all descendants in case there are container queries that use
font-relative units.

* Source/WebCore/style/StyleTreeResolver.h:

Canonical link: https://commits.webkit.org/267258@main




More information about the webkit-changes mailing list