[webkit-changes] [WebKit/WebKit] 7e52ab: Follow up to "[Xcode] Symlink to missing headers a...

[Elliott Williams]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7e52ab84d9d5432e26869afc46eda5479b434c23
      https://github.com/WebKit/WebKit/commit/7e52ab84d9d5432e26869afc46eda5479b434c23
  Author: Elliott Williams <emw at apple.com>
  Date:   2023-08-24 (Thu, 24 Aug 2023)

  Changed paths:
    M Source/WTF/Scripts/symlink-public-sdk-headers-for-embedded-platforms
    M WebKitLibraries/SDKs/appletvos16.0-additions.sdk/SymlinkedHeaders-output.xcfilelist
    M WebKitLibraries/SDKs/appletvos16.0-additions.sdk/SymlinkedHeaders.xcfilelist
    R WebKitLibraries/SDKs/appletvsimulator16.0-additions.sdk/SymlinkedHeaders-output.xcfilelist
    A WebKitLibraries/SDKs/appletvsimulator16.0-additions.sdk/SymlinkedHeaders-output.xcfilelist
    R WebKitLibraries/SDKs/appletvsimulator16.0-additions.sdk/SymlinkedHeaders.xcfilelist
    A WebKitLibraries/SDKs/appletvsimulator16.0-additions.sdk/SymlinkedHeaders.xcfilelist
    M WebKitLibraries/SDKs/iphonesimulator16.0-additions.sdk/SymlinkedHeaders-output.xcfilelist
    M WebKitLibraries/SDKs/iphonesimulator16.0-additions.sdk/SymlinkedHeaders.xcfilelist
    M WebKitLibraries/SDKs/iphonesimulator17.0-additions.sdk/SymlinkedHeaders-output.xcfilelist
    M WebKitLibraries/SDKs/iphonesimulator17.0-additions.sdk/SymlinkedHeaders.xcfilelist
    M WebKitLibraries/SDKs/watchos9.0-additions.sdk/SymlinkedHeaders-output.xcfilelist
    M WebKitLibraries/SDKs/watchos9.0-additions.sdk/SymlinkedHeaders.xcfilelist

  Log Message:
  -----------
  Follow up to "[Xcode] Symlink to missing headers and check in missing TBDs, instead of mutating the public SDK"
https://bugs.webkit.org/show_bug.cgi?id=259831
rdar://problem/113764577

Reviewed by Alexey Proskuryakov.

symlink-public-sdk-headers-for-embedded-platforms was making a shallow
directory comparison to determine whether a framework in an SDK had been
mutated by older versions of configure-xcode-for-embedded-development.
This resulted in false positives on machines which had *not* been
mutated. Fix by recursively comparing subdirs.

Also, some frameworks in configure-xcode-for-embedded-development were
marked as "optional", meaning they would *only* be used if an SDK did
not already provide its own version of that framework. For each of these
frameworks, remove them from additions SDKs'
SymlinkedHeaders.xcfilelists when they do already exist in that SDK.

* Source/WTF/Scripts/symlink-public-sdk-headers-for-embedded-platforms:
* WebKitLibraries/SDKs/appletvos16.0-additions.sdk/SymlinkedHeaders-output.xcfilelist:
* WebKitLibraries/SDKs/appletvos16.0-additions.sdk/SymlinkedHeaders.xcfilelist:
* WebKitLibraries/SDKs/iphonesimulator16.0-additions.sdk/SymlinkedHeaders-output.xcfilelist:
* WebKitLibraries/SDKs/iphonesimulator16.0-additions.sdk/SymlinkedHeaders.xcfilelist:
* WebKitLibraries/SDKs/iphonesimulator17.0-additions.sdk/SymlinkedHeaders-output.xcfilelist:
* WebKitLibraries/SDKs/iphonesimulator17.0-additions.sdk/SymlinkedHeaders.xcfilelist:
* WebKitLibraries/SDKs/watchos9.0-additions.sdk/SymlinkedHeaders-output.xcfilelist:
* WebKitLibraries/SDKs/watchos9.0-additions.sdk/SymlinkedHeaders.xcfilelist:

Canonical link: https://commits.webkit.org/267235@main