[webkit-changes] [WebKit/WebKit] 5e54c0: AX: aria-selected-menu-items test is flaky in ITM ...

Joshua Hoffman noreply at github.com
Thu Aug 24 01:47:45 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5e54c0b0e654c190747995a9eb69b9fe8aff90ee
      https://github.com/WebKit/WebKit/commit/5e54c0b0e654c190747995a9eb69b9fe8aff90ee
  Author: hoffmanjoshua <jhoffman23 at apple.com>
  Date:   2023-08-24 (Thu, 24 Aug 2023)

  Changed paths:
    M LayoutTests/accessibility-isolated-tree/TestExpectations
    M LayoutTests/accessibility/aria-selected-menu-items.html
    M LayoutTests/platform/glib/accessibility/aria-selected-menu-items-expected.txt
    M LayoutTests/platform/mac/accessibility/aria-selected-menu-items-expected.txt
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp

  Log Message:
  -----------
  AX: aria-selected-menu-items test is flaky in ITM mode
https://bugs.webkit.org/show_bug.cgi?id=260278
rdar://113979223

Reviewed by Chris Fleizach.

This change fixes aria-selected-menu-items in isolated tree mode by adding a traversal up for the newly selected child so that its ancestor
also updates its SelectedChildren property.
The traversal happens during a new case in AXObjectCache::updateIsolatedTree where the notification AXMenuListItemSelected is now handled.

* LayoutTests/accessibility-isolated-tree/TestExpectations

* LayoutTests/accessibility/aria-selected-menu-items.html
* LayoutTests/platform/mac/accessibility/aria-selected-menu-items-expected.txt
* LayoutTests/platform/glib/accessibility/aria-selected-menu-items-expected.txt

Tests updated to be async for ITM.

* Source/WebCore/accessibility/AXObjectCache.cpp
(WebCore::AXObjectCache::updateIsolatedTree):

Logic to handle AXMenuListItemSelected notifications.

* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp

Handle AXPropertyName::SelectedChildren in updateNodeProperties.

Canonical link: https://commits.webkit.org/267221@main




More information about the webkit-changes mailing list