[webkit-changes] [WebKit/WebKit] 9853d1: [CSS Container Queries] Container unit resolution ...

Antti Koivisto noreply at github.com
Wed Aug 23 09:49:52 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9853d19085bb0a308a87cd21447a9504c20d5427
      https://github.com/WebKit/WebKit/commit/9853d19085bb0a308a87cd21447a9504c20d5427
  Author: Antti Koivisto <antti at apple.com>
  Date:   2023-08-23 (Wed, 23 Aug 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-ineligible-container-expected.txt
    M Source/WebCore/css/CSSPrimitiveValue.cpp
    M Source/WebCore/css/query/ContainerQueryFeatures.cpp
    M Source/WebCore/rendering/RenderElement.cpp
    M Source/WebCore/rendering/RenderElement.h

  Log Message:
  -----------
  [CSS Container Queries] Container unit resolution should check the selected container is eligible
https://bugs.webkit.org/show_bug.cgi?id=260561
rdar://problem/114291153

Reviewed by Alan Baradlay.

* LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-ineligible-container-expected.txt:
* Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeNonCalcLengthDouble):

Loop until an eligible container is found.

* Source/WebCore/css/query/ContainerQueryFeatures.cpp:
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::hasEligibleContainmentForSizeQuery const):

Factor into a shared function.

* Source/WebCore/rendering/RenderElement.h:

Canonical link: https://commits.webkit.org/267192@main




More information about the webkit-changes mailing list