[webkit-changes] [WebKit/WebKit] 1534da: AX: AXObjectCache::handleAllDeferredChildrenChange...

AndresGonzalezApple noreply at github.com
Wed Aug 23 08:48:08 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1534dabccbb4b5b6cc80d8e072d77223a16a8a90
      https://github.com/WebKit/WebKit/commit/1534dabccbb4b5b6cc80d8e072d77223a16a8a90
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2023-08-23 (Wed, 23 Aug 2023)

  Changed paths:
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h

  Log Message:
  -----------
  AX: AXObjectCache::handleAllDeferredChildrenChanged doesn't need to call postPlatformNotification in MAC and IOS_FAMILY ports.
https://bugs.webkit.org/show_bug.cgi?id=260562
<rdar://problem/114292575>

Reviewed by Tyler Wilcock.

This patch is a follow up to the patch in https://bugs.webkit.org/show_bug.cgi?id=258998.

* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAllDeferredChildrenChanged):
Do not call postPlatformNotification for the COCOA platforms since AXChildrenChanged is not mapped to any platform notification. Even if this notification were mapped, like in the case of GTK, the update to the isolated tree should happen before a platform client is notify of a change. This patch also fixes that issue.

(WebCore::AXObjectCache::handleChildrenChanged):
Moved the postPlatformNotification call from this method to the above one.

(WebCore::AXObjectCache::updateIsolatedTree):
Removed the case for AXChildrenNotification since it is not used any longer.

* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateChildrenForObjects):
Added this new method with a FIXME comment for future optimization.

* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:

Canonical link: https://commits.webkit.org/267189@main




More information about the webkit-changes mailing list